Code review request for JEP-121

Vincent Ryan vincent.x.ryan at oracle.com
Tue Jun 5 09:01:02 PDT 2012


Thanks for those comments.

I've refactored the classes as suggested and generated a new webrev:
   http://cr.openjdk.java.net/~vinnie/6383200/webrev.01/


On 06/ 4/12 09:17 PM, Valerie (Yu-Ching) Peng wrote:
> Vinnie,
>
> I am still reviewing the changes.
> Just some quick comments and questions:
> Your current changes have both PBES1 and PBES2 impl inside the PBECipherCore.java but yet there is
> another new classPBES2Core.java  which seems to just delegate the calls to the internal PBECipherCore
> object.
>
> Have you considered splitting out the PBES2 impl from PBECipherCore into PBES2Core.java?
> Maybe renaming PBECipherCore to PBES1Core.java so it's clear that it's PBES1 impl only.
>
> Also, instead of encapsulating the PBEXXCore object and yet duplicating all the engineXXX methods
> which simply delegate to the implXXX calls, why not just extending from a common parent which extends
> the CipherSpi class and no need for the engineXXX methods for all children classes.
>
> Thanks,
> Valerie
>
>
> On 06/01/12 11:18, Vincent Ryan wrote:
>> Hello Valerie,
>>
>> Could you please review these changes for JEP-121:
>> http://cr.openjdk.java.net/~vinnie/6383200/webrev.00/
>>
>> Thanks.
>




More information about the security-dev mailing list