Code revire request: 6966259 (was Re: Avoid PrincipalName with realm == null)

Weijun Wang weijun.wang at oracle.com
Thu Jun 14 23:13:16 PDT 2012


>>> 3. Realm.java
>>> 63   } catch (KrbException ke) {
>>> 64      RealmException re = new RealmException(ke.getMessage());
>>> 65      re.initCause(ke);
>>> 66      throw re;
>>> 67  }
>>>
>>> I think you make a lot cleanup to exception thrown with just one call,
>>> like the one in KerberosPrincipal.java:
>>> -            IOException ioe = new IOException(e.getMessage());
>>> -            ioe.initCause(e);
>>> -            throw ioe;
>>> +            throw new IOException(e);
>>>
>>> Would you like to use the same style for the update in Realm.java?
>>
>> Unfortunately RealmException does not provide such a constructor. Are
>> you suggesting me to create one?
>>
> Why not? I think a Exception class should always have such constructor.

Good.

-Max

>
> Xuelei



More information about the security-dev mailing list