[7u4] Request for approval for CR 7088989 - Improve the performance for T4 by utilizing the newly provided crypto APIs

Andrew Hughes ahughes at redhat.com
Thu Mar 15 16:29:00 PDT 2012


----- Original Message -----
> On 3/14/12 9:08 AM, Andrew Hughes wrote:
> > 1.  java.security is altered to prioritise
> > com.oracle.security.ucrypto.UcryptoProvider
> > on Solaris builds.  What does this mean for OpenJDK builds on
> > Solaris that don't have
> > this provider?
> 
> Nothing, really.
> 
> > Will the provider code simply ignore absent providers?
> 
> Yes. The Providers are listed in preference order, if something can't
> be found in one of them,
> the search moves on to the next one, roughly speaking. For details,
> see
> http://docs.oracle.com/javase/7/docs/technotes/guides/security/crypto/CryptoSpec.html#ProviderInstalling
>  

Good.

> > 2.  Was there a reason the testcases in this commit were locked
> > down
> > to only work with the proprietary ucrypto provider?  Are they not
> > suitable for all providers?
> > They would be very useful for testing the SunPKCS11/NSS provider.
> 
> That's a question better suited for the security-dev at openjdk list.
> 

CCed.  As I said, I would have posted here first, if there had been a public review
of the patch to begin with.  There wasn't.

I noticed you don't seem to have commented on how this breaks the jdk7u guidelines.

> cheers,
> dalibor topic
> --
> Oracle <http://www.oracle.com>
> Dalibor Topic | Principal Product Manager
> Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961
> <tel:+491737185961>
> Oracle Java Platform Group
> 
> ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg
> 
> ORACLE Deutschland B.V. & Co. KG
> Hauptverwaltung: Riesstr. 25, D-80992 München
> Registergericht: Amtsgericht München, HRA 95603
> Geschäftsführer: Jürgen Kunz
> 
> Komplementärin: ORACLE Deutschland Verwaltung B.V.
> Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
> Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher
> 
> Green Oracle <http://www.oracle.com/commitment> Oracle is committed
> to developing practices and products that help protect the
> environment
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07




More information about the security-dev mailing list