Code review request, 7145960 sun/security/mscapi/ShortRSAKey1024.sh failing on windows

Bradford Wetmore bradford.wetmore at oracle.com
Thu May 17 17:02:04 UTC 2012


Looks good to me also.

Brad




On 5/17/2012 6:24 AM, Vincent Ryan wrote:
> Your fix looks fine. However you don't need to modify the file-separator
> on Windows - both forms are supported in pathnames.
>
>
> On 05/17/12 01:54 PM, Xuelei Fan wrote:
>> Hi,
>>
>> Please review the fix of test cases in Windows.
>>
>> webrev: http://cr.openjdk.java.net./~xuelei/7145960/webrev.00/
>>
>> Cause of the issue: when keytool cannot generate key pairs in Windows
>> system, we should exit the testing.
>>
>> Thanks,
>> Xuelei
>



More information about the security-dev mailing list