RFR, 8001579, eliminated compiler warnings in the JDK native security code

Chris Hegarty chris.hegarty at oracle.com
Mon Nov 5 15:37:46 UTC 2012


John,

This is very nice work, great to see these warnings being fixed.

One small issue though ( which Alan already mentioned ), I think you 
should revert the changes to src/share/native/sun/security/ec/impl/mpi.c 
. I grabbed your patch and I see problems with this change.

Otherwise, this looks good to me.

-Chris.

On 04/11/2012 08:55, John Zavgren wrote:
> Greetings:
>
> Please consider the webrev image (http://cr.openjdk.java.net/~chegar/8001579/webrev.01/) of changes I made to the native JDK security code to eliminate compiler warnings: used macros to convert from integers to pointers and vice versa; initialized data structures; fixed comparisons between integers of different types; etc.
>
> Thanks!
> John Zavgren
> john.zavgren at oracle.com
>



More information about the security-dev mailing list