RFR, 8001579, eliminated compiler warnings in the JDK native security code

Chris Hegarty chris.hegarty at oracle.com
Tue Nov 6 14:15:57 UTC 2012


Changes look good to me. If no one on the security team has a problem 
with this, I can sponsor the change for John.

-Chris.

On 11/05/2012 09:34 PM, John Zavgren wrote:
> All:
> Please consider the following minor modifications to the compiler warning code changes:
>
> http://cr.openjdk.java.net/~chegar/8001579/webrev.02/
>
> I reverted the changes I had made to the file: src/share/native/sun/security/ec/impl/mpi.c, and I added a cast to GSSLibStub.c in the procedure: Java_sun_security_jgss_wrapper_GSSLibStub_getMechPtr to be sure that the "size" argument in memcmp has the right value. The first change created a bug that was detected by jprg. I'll investigate this more at a later time.
>
> Thanks!
> John Zavgren
>
>
> ----- Original Message -----
> From: john.zavgren at oracle.com
> To: security-dev at openjdk.java.net
> Sent: Sunday, November 4, 2012 3:55:20 AM GMT -05:00 US/Canada Eastern
> Subject: RFR, 8001579, eliminated compiler warnings in the JDK native security code
>
> Greetings:
>
> Please consider the webrev image (http://cr.openjdk.java.net/~chegar/8001579/webrev.01/) of changes I made to the native JDK security code to eliminate compiler warnings: used macros to convert from integers to pointers and vice versa; initialized data structures; fixed comparisons between integers of different types; etc.
>
> Thanks!
> John Zavgren
> john.zavgren at oracle.com
>



More information about the security-dev mailing list