Code Review Request for 6996769: support AEAD ciphers

[Valerie (Yu-Ching) Peng]

Max,

Update: I removed the block (starting line 580 in CipherCore.java) for 
handling RC2 since it's never used.

It turns out that the current impl in RC2Cipher always convert the 
AlgorithmParameters object to RC2ParameterSpec and only uses 
CipherCore.init(..., AlgorithmParameterSpec,...) method. Thus, I won't 
be adding a regression test, but rather simply document the current 
RC2Cipher behavior in CipherCore.java to clarify things up.

The updated webrev is at:
http://cr.openjdk.java.net/~valeriep/6996769/webrev.01/

Xuelei brought up the issue of enforcing (Key+IV) uniqueness for GCM 
mode during this afternoon's meeting.
I think more changes may be made after we decide what to do.
So, there may be a webrev.02 coming... Just a heads up.

Thanks!
Valerie

On 11/07/12 14:48, Valerie (Yu-Ching) Peng wrote:
>> 580                  } else if (key.getAlgorithm().equals("RC2")) {
>>
>> This seems a bug fix. Is there a regression test for it?
> I just noticed this problem when make the enhancement for GCM mode.
> I will add a regression test for this.