Code review request, JDK-8001569 Regression test GetPeerHost uses static port number

Brad Wetmore bradford.wetmore at oracle.com
Fri Nov 9 18:25:44 UTC 2012


I'm surprised we are still finding these!  ;)  I though we had fixed 
most of them already.  Maybe whoever fixed them was looking for 
443/80/8080, and missed 9999?

Brad


On 11/9/2012 1:20 AM, Chris Hegarty wrote:
> Looks fine Xuelei.
>
> -Chris.
>
> On 09/11/2012 05:27, Xuelei Fan wrote:
>> webrev: http://cr.openjdk.java.net./~xuelei/8001569/webrev.00/
>>
>> Test case,
>> test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ServerHandshaker/GetPeerHost.java,
>>
>> uses the static port number, and does not close the socket explicitly.
>> As may result that the socket/port cannot be released in time in OS
>> level.
>>
>> The fix will use dynamically allocated server port.
>>
>> Thanks,
>> Xuelei



More information about the security-dev mailing list