7194449: String resources for Key Tool and Policy Tool should be in their respective packages

Sean Mullan sean.mullan at oracle.com
Fri Oct 5 13:48:46 PDT 2012


Hi Steve,

I've reviewed this and it looks good. One small nit is to add the @Override
annotation to the getContents() method of all of the Resources* classes.

Send me the latest patch when you are ready and I will push it for you.

--Sean


On 9/20/12 9:49 PM, Stephen Flores wrote:
> Max, Sean, Alan,
> 
> Please review this webrev:
> 
>   http://cr.openjdk.java.net/~sflores/7194449/webrev-0/
> 
> Note: I will respond to any comments when I get back from vacation on 
> Monday Oct. 1.
> 
> Changes:
> 
>    Moved jarsigner and keytool into their own packages as was done
>    for policytool. Unit tests and release.gmk were updated.
> 
>    Static methods in keytool called by jarsigner were moved to
>    sun.security.tools.KeyStoreUtil.
> 
>    Spit out the String resources for keytool and policytool from
>    sun.security.util.Resources into their respective packages.
> 
> Sean,
> 
> If everything is OK, can you commit the changes?
> 
> Thanks,
> 
>    Steve.
> 



More information about the security-dev mailing list