Code review request, JEP 114, 7068321 Support TLS Server Name Indication (SNI) Extension in JSSE Server

[Xuelei Fan]

On 10/11/2012 12:21 PM, Bradford Wetmore wrote:
> 
> 
> On 10/10/2012 7:54 PM, Xuelei Fan wrote:
>> No new webrev. I need a review of how to use SNIMatcher. See bellow
>> inline comments.
>>
>> On 10/11/2012 7:38 AM, Brad Wetmore wrote:
>>>
>>>
>>> On 10/10/2012 5:47 AM, Xuelei Fan wrote:
>>>> new webrev: http://cr.openjdk.java.net./~xuelei/7068321/webrev.13/
>>>
>>> I guess you didn't need to have me as reviewer before going final with
>>> the CCC?
>>>
>> The CCC has been finalized. ;-) I though you have done with spec review.
>>   Anyway, we still can make updates on specification within new bugs.
>>
>>>>> javax/net/ssl/SSLSocketFactory.java
>>>>> ===================================
>>>>> Change look good.
>>>>>
>>>>> 216:  I think you need a period at end of sentence here.
>>>
>>> You got the others, but missed this one.
>>>
>> I think we discussed the style sometimes ago.  If the sentence does not
>> start with a capital letter, then it does not need a period at the end
>> of the sentence.  I can see both style in other specs.
>>
>> Updated to add the period.
> 
> Sorry, I meant to say copyright change.  Boy, did I goof on that one.
> One of the copyright dates wasn't right, but the rest were.

Oops, right,  I missed the copyright dates. I double checked the
copyright yesterday, but still missed this one. ;-)

Xuelei