Code review request: 8001208: Fix for KRB5CCNAME not complete

Weijun Wang weijun.wang at oracle.com
Mon Oct 22 11:34:17 UTC 2012


Thanks. Will add some comments.

-Max

在 Oct 22, 2012,7:30 PM,Xuelei Fan <xuelei.fan at oracle.com> 写道:

> Looks fine to me.  I would suggest you add a few lines about the prefix
> of KRB5CCNAME in the method comment.
> 
> Xuelei
> 
> On 10/22/2012 2:38 PM, Weijun Wang wrote:
>> Please take a look at
>> 
>>   http://cr.openjdk.java.net/~weijun/8001208/webrev.00/
>> 
>> An old test is enhanced to check for the fix.
>> 
>> Honestly, it might be best to check for KRB5CCNAME outside
>> FileCredentialsCache since the ccache type can be something other than
>> FILE:. It will touch more files and I decide to delay this enhancement
>> until we start supporting more real types.
>> 
>> Also, I want to backport this fix to 7u, so it had better be simple.
>> 
>> Thanks
>> Max
> 



More information about the security-dev mailing list