7u10 Request for review: 7054918, 7055362, 7055363

Jason Uh jason.uh at oracle.com
Wed Sep 12 06:01:47 UTC 2012



On 09/11/2012 09:12 PM, Weijun Wang wrote:
>
>
> On 09/12/2012 08:48 AM, Jason Uh wrote:
>> Hi all,
>>
>> Could I please get a review for a backport of Max's test cleanups for
>> jdk_security{1|2|3}?
>>
>> 7054918 -- jdk_security1 test target cleanup
>> Webrev: http://cr.openjdk.java.net/~juh/7054918/webrev.7u.00/
>> JDK8 Changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a015dda3bdc6
>> CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7054918
>
> Good.
>
>>
>> 7055362 -- jdk_security2 test target cleanup
>> Webrev: http://cr.openjdk.java.net/~juh/7055362/webrev.7u.00/
>> JDK8 Changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/febb7f557135
>> CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7055362
>
> jdk_security2 should use agenvm mode now.
>

I'll make this change.

>>
>> 7055363 -- jdk_security3 test target cleanup
>> Webrev: http://cr.openjdk.java.net/~juh/7055363/webrev.7u.00/
>> JDK8 Changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb83fe13af98
>> CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7055363
>
> Will take a look.
>
> BTW, have you run the new test targets on JPRT?
>

Yes. For each of the changesets, the corresponding test targets ran 
successfully. Is that sufficient?

Thanks,
Jason

> Thanks
> Max
>
>>
>> Thanks,
>> Jason



More information about the security-dev mailing list