Quick Codereview
Brad Wetmore
bradford.wetmore at oracle.com
Wed Sep 12 07:39:46 UTC 2012
Valerie/Sean,
Here's the change for JDK8.
7197071: Makefiles for various security providers aren't including the
default manifest.
I've added the standard/regular rt.jar attributes (see
common/Release.gmk) to the remainder of the JCE jars (see
javax/crypto/Makefile and com/sun/crypto/provider/Makefile), and my
regression test makes sure that the Specification version value lines up
with the Implementation Version value.
This does have the side effect that when we are transitioning major
releases, this test will fail until the providers are rebuilt. This is
an acceptable amount of noise (once per release), since that should is
an actual failure.
One minor addition from the previous version you saw, the reg test has
been enhanced, and the Defs-jce.gmk file was updated to remove the -ea
string, which was causing some confusion.
Thanks,
http://cr.openjdk.java.net/~wetmore/7197071/webrev.01/
Brad
More information about the security-dev
mailing list