7u10 Request for review: 7054918, 7055362, 7055363

[Weijun Wang]

Also, remember to also backport the code changes in the jdk/test/closed repo for the same CRs. They should be fixed at the same time.

-Max

在 Sep 12, 2012，2:06 PM， Jason Uh 写道：

> 
> 
> On 09/11/2012 09:41 PM, Xuelei Fan wrote:
>> Hi Jason,
>> 
>> Thanks for take care of this. I only reviewed a few of update on SSL.
>> 
>> In the following example, the comment in the following lines of "run"
>> tag is treated as arguments of the test.
>> -------------------------------------------------------
>> + * @run main/othervm ServerTimeout
>> + *
>> + *     SunJSSE does not support dynamic system properties, no way to re-use
>> + *     system properties in samevm/agentvm mode.
>> -------------------------------------------------------
>> 
>> The above command is equals to:
>>     run main/othervm ServerTimeout SunJSSE does not ... mode.
>> 
>> It's confusing!
>> 
>> 
>> I would suggest to use the following style to run SSL test under othervm.
>> -------------------------------------------------------
>> +
>> + //
>> + // SunJSSE does not support dynamic system properties, no way to
>> + // re-use system properties in samevm/agentvm mode.
>> + //
>> +
>>  /*
>>   * @test
>>   * @bug 4836493
>>   * @summary Socket timeouts for SSLSockets causes data corruption.
>> + * @run main/othervm ServerTimeout
>>   */
>> -------------------------------------------------------
>> 
> 
> Thanks! I'll include this formatting change in my next webrev.
> 
>> 
>> Generally, it takes a lot of time to evaluate whether a SSL test does
>> not make use of the system properties.  An indeed, only a very few SSL
>> tests are not initialized with system properties.  So I would suggest
>> always using othervm for all SSL and HTTPS tests, with above style.
>> 
>> Thanks,
>> Xuelei
>> 
>> On 9/12/2012 8:48 AM, Jason Uh wrote:
>>> Hi all,
>>> 
>>> Could I please get a review for a backport of Max's test cleanups for
>>> jdk_security{1|2|3}?
>>> 
>>> 7054918 -- jdk_security1 test target cleanup
>>> Webrev: http://cr.openjdk.java.net/~juh/7054918/webrev.7u.00/
>>> JDK8 Changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a015dda3bdc6
>>> CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7054918
>>> 
>>> 7055362 -- jdk_security2 test target cleanup
>>> Webrev: http://cr.openjdk.java.net/~juh/7055362/webrev.7u.00/
>>> JDK8 Changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/febb7f557135
>>> CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7055362
>>> 
>>> 7055363 -- jdk_security3 test target cleanup
>>> Webrev: http://cr.openjdk.java.net/~juh/7055363/webrev.7u.00/
>>> JDK8 Changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb83fe13af98
>>> CR:  http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7055363
>>> 
>>> Thanks,
>>> Jason
>>