7194449: String resources for Key Tool and Policy Tool should be in their respective packages
Weijun Wang
weijun.wang at oracle.com
Fri Sep 21 07:45:44 UTC 2012
Looks fine. I'm only not sure if dividing sun.security.util.Resources
into 3 files is safe. Is it possible that a string is shared by them? I
noticed you keep a duplicate of "NEWLINE". Hopefully you already figured
out all cases.
Thanks
Max
On 09/21/2012 09:49 AM, Stephen Flores wrote:
> Max, Sean, Alan,
>
> Please review this webrev:
>
> http://cr.openjdk.java.net/~sflores/7194449/webrev-0/
>
> Note: I will respond to any comments when I get back from vacation on
> Monday Oct. 1.
>
> Changes:
>
> Moved jarsigner and keytool into their own packages as was done
> for policytool. Unit tests and release.gmk were updated.
>
> Static methods in keytool called by jarsigner were moved to
> sun.security.tools.KeyStoreUtil.
>
> Spit out the String resources for keytool and policytool from
> sun.security.util.Resources into their respective packages.
>
> Sean,
>
> If everything is OK, can you commit the changes?
>
> Thanks,
>
> Steve.
>
More information about the security-dev
mailing list