7194449: String resources for Key Tool and Policy Tool should be in their respective packages

Weijun Wang weijun.wang at oracle.com
Fri Sep 21 03:56:19 PDT 2012



On 09/21/2012 06:29 PM, Alan Bateman wrote:
> On 21/09/2012 02:49, Stephen Flores wrote:
>> Max, Sean, Alan,
>>
>> Please review this webrev:
>>
>>  http://cr.openjdk.java.net/~sflores/7194449/webrev-0/
>>
>> Note: I will respond to any comments when I get back from vacation on
>> Monday Oct. 1.
>>
>> Changes:
>>
>>   Moved jarsigner and keytool into their own packages as was done
>>   for policytool. Unit tests and release.gmk were updated.
>>
>>   Static methods in keytool called by jarsigner were moved to
>>   sun.security.tools.KeyStoreUtil.
>>
>>   Spit out the String resources for keytool and policytool from
>>   sun.security.util.Resources into their respective packages.
>>
>> Sean,
>>
>> If everything is OK, can you commit the changes?
>>
>> Thanks,
>>
>>   Steve.
>>
> I skimmed through this and I'm sure Sean and Max will give it a detailed
> reviewed.
>
> Overall it looks very good to me, the only thing that I'm not sure about
> is the resources for keytool. As they are in sun.security.tools.keytool
> it means they will all need to be included with the tool. If you wanted
> a en_US vs. all split without splitting packages then it would meaning
> moving them again.

So, maybe you should split the package?

>
> I agree with Max's question about whether you need to leave a
> sun.security.tools.KeyTool in case anyone invokes it directly (no one
> should be dependent on sun.security.** classes of course but still
> working considering).
>
> In sun/security/tools/KeyStoreUtil.java then maybe getPassWithModifier
> can use try-with-resources.
>
> Is the change to sun/security/tools/keytool/autotest.sh just a merge issue?

No, that was a new line so cannot be a merge issue.

Anyway, either the word should be OK.

-Max

>
> -Alan.
>
>



More information about the security-dev mailing list