Code Review Request for 7196009

Wang Weijun weijun.wang at oracle.com
Thu Apr 18 20:24:08 PDT 2013


The parseStringValue method is definitively better. It is also consistent with other fields.

But I'm not sure what parseLine means. So if we are going to add any special characters to the description field, do we need to escape anything? What if we add quotation marks there?

I'm not near a computer so I cannot try it out.

-Max

ÔÚ Apr 19, 2013£¬10:38£¬"Valerie (Yu-Ching) Peng" <valerie.peng at oracle.com> дµÀ£º

> Max,
> 
> Do you have time to review the following fix?
> 7196009: SunPkcs11 provider fails to parse config path containing parenthesis
> 
> I made the adjustments to support quoted strings for the library path settings in the PKCS11 provider configuration file.
> If the path contain parenthesis or spaces, then the value should be quoted, so the whole thing would be taken as is.
> 
> Webrev: http://cr.openjdk.java.net/~valeriep/7196009/webrev.00/
> 
> Thanks,
> Valerie


More information about the security-dev mailing list