Code Review Requests for 7196382 and 8010134

[Xuelei Fan]

On 4/19/2013 10:43 AM, Valerie (Yu-Ching) Peng wrote:
> Xuelei,
> 
> Do you have time to review the following two fixes?
> 7196382: PKCS11 provider should support 2048-bit DH
> 8010134: A finalizer in sun.security.pkcs11.wrapper.PKCS11 perhaps
> should be protected
> 
> The first one removes the hardcoded limit of 1024 for DH and the second
> one is making the finalize() method protected.
> 
> Webrevs:
> http://cr.openjdk.java.net/~valeriep/7196382/webrev.00/
Looks fine.

Do we plan to support DH keys bwteen 1024 and 2048 with default (null)
parameters, for example 1536, in PKCS11 provider?  Recently, I run into
a case that uses DH public keys of 1536 bits. I was wondering we may
also want to support more.

> http://cr.openjdk.java.net/~valeriep/8010134/webrev.00/
Looks fine.

Xuelei

> 
> Thanks!
> Valerie