Code Review Request for 7196009

[Weijun Wang]

No more comment.

Thanks
Max

On 4/23/13 7:28 AM, Valerie (Yu-Ching) Peng wrote:
> 
> Yes, I think the original impl which uses parseLine() to process the
> path values is incorrect since whatever specified should be preserved as
> a whole.
> 
> Currently, the parseLine() is only used for parsing descriptions. The
> description line cannot contain special characters, otherwise an
> exception will be thrown indicating that an unexpected token has been
> encountered.
> If you were try to use quoted string for description, I think it will
> leads to the unexpected token exception. Not very accommodating perhaps.
> But since description is more for information purpose, I don't think
> this will be an issue and thus, I have just left it as is.
> 
> If you have more comments, please let me know. Otherwise, I will proceed
> with integration in a day or two.
> 
> Thanks,
> Valerie
> 
> On 04/18/13 20:24, Wang Weijun wrote:
>> The parseStringValue method is definitively better. It is also consistent with other fields.
>>
>> But I'm not sure what parseLine means. So if we are going to add any special characters to the description field, do we need to escape anything? What if we add quotation marks there?
>>
>> I'm not near a computer so I cannot try it out.
>>
>> -Max
>>
>> 在 Apr 19, 2013，10:38，"Valerie (Yu-Ching) Peng" <valerie.peng at oracle.com> 写道：
>>
>>> Max,
>>>
>>> Do you have time to review the following fix?
>>> 7196009: SunPkcs11 provider fails to parse config path containing parenthesis
>>>
>>> I made the adjustments to support quoted strings for the library path settings in the PKCS11 provider configuration file.
>>> If the path contain parenthesis or spaces, then the value should be quoted, so the whole thing would be taken as is.
>>>
>>> Webrev: http://cr.openjdk.java.net/~valeriep/7196009/webrev.00/
>>>
>>> Thanks,
>>> Valerie
>