Code Review Request for 7196009

[Valerie (Yu-Ching) Peng]

The concurrent config parsing impl in SunPKCS11 provider may seem more 
complicated than necessary at the first sight.
However, it has several advantages: this strict parsing can detect 
invalid settings right at parsing time and fail if any error is 
detected. Special handling for different keys, i.e. $XXX expansion for 
certain keys but not the rest, are possible.

With the Properties class, the syntax can be too loosely defined, i.e. 
each of the following three lines specifies the key |"Truth"| and the 
associated element value |"Beauty"|:

  Truth = Beauty
   Truth:Beauty
  Truth                    :Beauty


For the more complicated configuration attribute such as "attributes" 
whose value spans over multiple lines, it may not be that conveniently 
handled by using Properties class.

Thanks,
Valerie

On 04/18/13 23:38, Matthew Hall wrote:
> One question. Why does it parse these manually instead of using the Properties class to do it? That would work a lot better and reduce complexity and bugs.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20130422/fc8b8751/attachment.htm>