Code review: 8001284 & 8012971

Anthony Scarpino anthony.scarpino at oracle.com
Tue Apr 23 22:05:43 UTC 2013


Sure, that sounds good.

Tony

On 04/23/2013 03:03 PM, Valerie (Yu-Ching) Peng wrote:
>
> Both fixes look fine.
> However, for easier tracking, it's better to separate them out into 2
> separate webrevs under their corresponding bug ids.
> Can you please do that?
> Thanks,
> Valerie
>
> On 04/22/13 14:18, Anthony Scarpino wrote:
>> This code review is for the following two bugs:
>> - 8001284 Buffer problems with SunPKCS11-Solaris and CKM_AES_CTR
>> - 8012971 PKCS11Test hiding exception failures
>>
>> The first fix is simple as it prevents the method from enforcing AES
>> block lengths on CTR, a stream cipher.
>>
>> The second fix is a test problem that is suppressing test failures.
>> NOTE: the diffs in webrev are hiding the change in indention for the
>> "if (found)" change.  Don't know why webrev is set this way, but
>> looking at the non-diff links shows the proper indention.
>>
>> http://cr.openjdk.java.net/~ascarpino/8001284/webrev.00/
>>
>> thanks
>>
>> Tony
>>
>




More information about the security-dev mailing list