RFR: 8015669: KerberosPrincipal::equals should ignore name-type

Sean Mullan sean.mullan at oracle.com
Mon Aug 26 10:45:33 PDT 2013


Looks fine. A minor suggestion is that the code in equals could be 
simplified a little:

     if (! (other instanceof KerberosPrincipal)) {
         return false;
     }
     String myFullName = getName();
     String otherFullName = ((KerberosPrincipal) other).getName();
     return myFullName.equals(otherFullName);

--Sean

On 08/25/2013 11:42 PM, Weijun Wang wrote:
> Hi Sean
>
> Please look at the webrev at
>
>    http://cr.openjdk.java.net/~weijun/8015669/webrev.00/
>
> A new regression test is added.
>
> Thanks
> Max



More information about the security-dev mailing list