Code Review request: 8029550 javadoc updates

Sean Mullan sean.mullan at oracle.com
Thu Dec 5 10:31:11 PST 2013


On 12/04/2013 08:46 PM, Bradford Wetmore wrote:
> I really don't think formatting changes as part of other approved
> changes would be taboo.  Joe Darcy has the same opinion.  I would
> restore, but too late now.  I knew I should have got to this email
> earlier.  :)

Technically, I think we are still bending the rules, since we are 
touching code as part of what is supposed to be a docs-only fix. Sure, 
there's almost no chance we would break something by including these, 
but I guess I'm just a stickler on rules ...

--Sean

>
> One question, I haven't tried this out, but will the simple @since 8
> additions clobber all of the existing "Description copied from..." in
> methods like getOrDefault() ?  If so, then we should probably wait until
> that bug is fixed.
>
> Brad
>
>
>
>
>
> On 12/4/2013 12:32 PM, Anthony Scarpino wrote:
>> Ok.. I've removed the formatting changes and updated the webrev in-place.
>>
>> Tony
>>
>> On 12/04/2013 11:52 AM, Sean Mullan wrote:
>>> Looks ok to me. I'm not really sure if code formatting changes are
>>> considered a docs change though, I think this is stretching the
>>> definition, so I would probably just make the @since changes.
>>>
>>> --Sean
>>>
>>> On 12/04/2013 02:14 PM, Anthony Scarpino wrote:
>>>> Hi,
>>>>
>>>> I need a quick review of the below.  The changes reflect comments that
>>>> Brad made about javadoc @since tags not being inherited from the new
>>>> methods, additionally some formatting changes.  No code changes were
>>>> made
>>>>
>>>> 8029550 javadoc since tag and formatting updates for recent Hashtable
>>>> updates
>>>>
>>>> http://cr.openjdk.java.net/~ascarpino/8029550/webrev.00/
>>>>
>>>> Tony
>>>
>>



More information about the security-dev mailing list