Code Review request: 8028431: NullPointerException in DerValue.equals(DerValue)
Vincent Ryan
vincent.x.ryan at oracle.com
Fri Dec 20 13:19:14 UTC 2013
Hello Artem,
You fix looks good. You just need to fill in the missing portion
of the copyright in the test. You could also adjust the copyright
year range at the start of DerValue.java.
Also I would add the test to the existing
test/java/security/cert/X509Certificate/ directory rather than create a
new one.
Finally, I think the test should run fine without the jtreg
tag for 'othervm'.
Thanks.
On 20/12/2013 12:51, Artem Smotrakov wrote:
> Hi,
>
> please review this fix for 9:
>
> https://bugs.openjdk.java.net/browse/JDK-8028431
> http://cr.openjdk.java.net/~asmotrak/8028431/webrev.00/
> <http://cr.openjdk.java.net/%7Easmotrak/8028431/webrev.00/>
>
> sun.security.util.DerValue.equals(DerValue) method does not check that
> null is passed. As a result, NullPointerException can occur.
>
> Artem
More information about the security-dev
mailing list