Code Review request: 8028431: NullPointerException in DerValue.equals(DerValue)

[Vincent Ryan]

All looks good now. Thanks.


On 20/12/2013 14:05, Artem Smotrakov wrote:
> Hello Vincent,
>
> Thanks for your feedback.
>
> I heve updated the webrev with the following:
>   - the test moved to the existing
> test/java/security/cert/X509Certificate/ directory
>   - copyright in the test
>   - copyright year at the start of DerValue.java
>
> There was no 'othervm' tag in the test. Did I miss something?
>
> Please take a look:
> http://cr.openjdk.java.net/~asmotrak/8028431/webrev.01/
> <http://cr.openjdk.java.net/%7Easmotrak/8028431/webrev.01/>
>
> Artem
>
> On 12/20/2013 05:19 PM, Vincent Ryan wrote:
>> Hello Artem,
>>
>> You fix looks good. You just need to fill in the missing portion
>> of the copyright in the test. You could also adjust the copyright
>> year range at the start of DerValue.java.
>>
>> Also I would add the test to the existing
>> test/java/security/cert/X509Certificate/ directory rather than create
>> a new one.
>>
>> Finally, I think the test should run fine without the jtreg
>> tag for 'othervm'.
>>
>> Thanks.
>>
>>
>> On 20/12/2013 12:51, Artem Smotrakov wrote:
>>> Hi,
>>>
>>> please review this fix for 9:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8028431
>>> http://cr.openjdk.java.net/~asmotrak/8028431/webrev.00/
>>> <http://cr.openjdk.java.net/%7Easmotrak/8028431/webrev.00/>
>>>
>>> sun.security.util.DerValue.equals(DerValue) method does not check that
>>> null is passed. As a result, NullPointerException can occur.
>>>
>>> Artem
>