Code review request, 8025415, Test SSLSocketImplThrowsWrongExceptions.java timed out

[Xuelei Fan]

On 12/25/2013 11:09 AM, Weijun Wang wrote:
> Overall it's good, but the exception dealing part can be cleaner.
>
>   230         Exception exception = null;
>   231
>   232         /*
>   233          * Check various exception conditions.
>   234          */
>   235         if ((local != null) && (remote != null)) {
>   236             // If both failed, return the curthread's exception.
>   237             local.initCause(remote);
>   238             exception = local;
>   239         } else if (local != null) {
>   240             exception = local;
>   241         } else if (remote != null) {
>   242             exception = remote;
>   243         } else if (startException != null) {
>   244             exception = startException;
>   245         }
>   246
>   247         /*
>   248          * If there was an exception *AND* a startException,
>   249          * output it.
>   250          */
>   251         if (exception != null) {
>   252             if (exception != startException && startException !=
> null) {
>   253                 exception.addSuppressed(startException);
>   254             }
>   255             throw exception;
>   256         }
>
> How about removing lines 243-244 and deal with startException only in
> the if block from line 251?
>
Good idea.

I will consider this improvement in JDK-8019776, "Make the JSSE Test 
Templates into a library".  Keep the code the same as SSLSocketTemplate 
make it easier to move to use new library in the future.

Thanks,
Xuelei

> Thanks
> Max
>
>
> On 12/25/13, 10:55, Xuelei Fan wrote:
>> ping ...
>>
>> On 12/20/2013 4:14 PM, Xuelei Fan wrote:
>>> Hi Weijun,
>>>
>>> Another simple test stabilization fix.
>>>
>>> webrev: http://cr.openjdk.java.net/~xuelei/8025415/webrev.00/
>>>
>>> This intermittent failure may caused by that server may also throw
>>> exception, which cannot be caught with current client-server test
>>> template.
>>>
>>> This fix is trying to use the new SSL socket test template
>>> (test/sun/security/ssl/templates/SSLSocketTemplate.java), which is more
>>> reliable.  Not too much effort, just copy/past, and use the new test
>>> template.
>>>
>>> Thanks,
>>> Xuelei
>>