RFR JDK-8014307

[John Zavgren]

All:
Please give this change one more consideration.

Thanks!
John


-------- Original Message --------
Subject: 	Re: Re: RFR JDK-8014307
Date: 	Fri, 24 May 2013 15:56:11 -0400
From: 	John Zavgren <john.zavgren at oracle.com>
To: 	Security-Dev <security-dev at openjdk.java.net>



Thanks, Valerie. I removed the unnecessary resetGSSBuffer(...) call. The 
revised webrev is viewable at:
http://cr.openjdk.java.net/~jzavgren/8014307/webrev.03/ 
<http://cr.openjdk.java.net/%7Ejzavgren/8014307/webrev.03/>

John
> -------- Original Message --------
> Subject:     Re: RFR JDK-8014307
> Date:     Wed, 22 May 2013 16:18:33 -0700
> From:     Valerie (Yu-Ching) Peng <valerie.peng at oracle.com>
> Reply-To: valerie.peng at oracle.com
> To: security-dev at openjdk.java.net
>
>
>
> The resetGSSBuffer(..) call on line 829 should be removed as the inToken
> structure isn't even initialized yet (initGSSBuffer call is on line 833).
> Rest looks fine.
> Thanks,
> Valerie
>
> On 05/22/13 11:54, John Zavgren wrote:
>> Greetings:
>> I just updated:
>> /jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c
>> /with the recommended changes.
>>
>> http://cr.openjdk.java.net/~jzavgren/8014307/webrev.02/
>>
>> Thanks!
>> John Zavgren
>> ----------------------------------------------------------------------
>>
>>
>> John,
>>
>> 1) 332-333 can be replaced w/ a deleteGSSOID(nameType) call. Also, with
>> this deleteGSSOID(nameType) call, we should also add  the following 
>> line:
>>       resetGSSBuffer(env, jnameVal, &nameVal);
>>
>> 2) I think the ExceptionCheck block on line 932 should also be enhanced
>> w/ resetGSSBuffer(env, jinToken, &inToken) call as well as free(cb)
>> call. Same goes for another ExceptionCheck blocks on line 984, 998, 
>> 1024.
>>
>> Thanks,
>> Valerie
>> On 05/14/13 19:19, John Zavgren wrote:
>> >/  Greetings: Please review the following change to the file:
>> />/ jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c that 
>> fixes
>> />/  two memory leaks.
>> />/ http://cr.openjdk.java.net/~jzavgren/8014307/webrev.01/ 
>> <http://cr.openjdk.java.net/%7Ejzavgren/8014307/webrev.01/> Thanks! John
>> />/  Zavgren/
>> -- 
>> John Zavgren
>> john.zavgren at oracle.com
>> 603-821-0904
>> US-Burlington-MA
>
>
>


-- 
John Zavgren
john.zavgren at oracle.com
603-821-0904
US-Burlington-MA



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20130613/64e9affd/attachment.htm>