Code review request, JDK-8005535: SSLSessionImpl should have protected finalize()

Xuelei Fan xuelei.fan at oracle.com
Thu May 9 14:49:35 UTC 2013


On 5/9/2013 10:45 PM, Weijun Wang wrote:
> There is no need to add final there.
> 
No, it is not necessary. I added the keyword just to make it "feel" more
match the Object.finalize() declaration.

Thanks,
Xuelei

> -Max
> 
> On 5/9/13 10:39 PM, Xuelei Fan wrote:
>> Hi Max,
>>
>> Please review the simple fix to properly override the finalize() method.
>>
>> http://cr.openjdk.java.net/~xuelei/8005535/webrev.00/
>>
>> Trivial update, no new regression test.
>>
>> Thanks,
>> Xuelei
>>




More information about the security-dev mailing list