Code Review: 7160837 DigestOutputStream does not turn off digest calculation when "close()" is called

[Anthony Scarpino]

Sure..

Tony

On 05/26/2013 09:52 PM, Xuelei Fan wrote:
> Looks fine to me, except a very minor coding style comment:
>
> CipherInputStream.java
> ======================
>   307   }
>   308   catch (BadPaddingException | IllegalBlockSizeException ex) {}
>
> I would prefer a style as:
>   307   } catch (BadPaddingException | IllegalBlockSizeException ex) {
>   308   }
>
> Xuelei
>
> On 5/22/2013 1:42 AM, Anthony Scarpino wrote:
>> ping...
>>
>> No comments?  Perfect? :-)
>>
>> On May 14, 2013, at 8:15 AM, Anthony Scarpino <anthony.scarpino at oracle.com> wrote:
>>
>>> Hi,
>>>
>>> Below is the link to code changes for:  DigestOutputStream does not turn off digest calculation when "close()" is called.
>>>
>>> The more significant change is to the Cipher streams to prevent extra doFinal() calls.
>>>
>>> http://cr.openjdk.java.net/~ascarpino/7160837/webrev.00/
>>>
>>> thanks
>>>
>>> Tony
>