Code review: 8001284 & 8012971

[Brad Wetmore]

Tony,

 >> NOTE: the diffs in webrev are hiding the change in indention for the
 >> "if (found)" change.  Don't know why webrev is set this way, but
 >> looking at the non-diff links shows the proper indention.

FYI: webrev's -b option will cause webrev to not ignore changes in the 
amount of white space.  I'm guessing the concern is more for the actual 
code than whitespace, and listing whitespace changes just adds "useless" 
noise/overhead to the review.  (But I do notice that kind of stuff!  ;))

Brad


> On 04/22/13 14:18, Anthony Scarpino wrote:
>> This code review is for the following two bugs:
>> - 8001284 Buffer problems with SunPKCS11-Solaris and CKM_AES_CTR
>> - 8012971 PKCS11Test hiding exception failures
>>
>> The first fix is simple as it prevents the method from enforcing AES
>> block lengths on CTR, a stream cipher.
>>
>> The second fix is a test problem that is suppressing test failures.
>> NOTE: the diffs in webrev are hiding the change in indention for the
>> "if (found)" change.  Don't know why webrev is set this way, but
>> looking at the non-diff links shows the proper indention.
>>
>> http://cr.openjdk.java.net/~ascarpino/8001284/webrev.00/
>>
>> thanks
>>
>> Tony
>>
>