[security dev] [8] Review request for JDK-8028266 : Tidy warnings cleanup for packages java.security/javax.security

[Joe Darcy]

Might just be my limited knowledge of HTML, but I don't understand the 
replacement of <p> with <br/> in several places like:

--- 
old/src/share/classes/javax/security/auth/kerberos/DelegationPermission.java 
2013-11-14 07:44:04.878682607 +0000
+++ 
new/src/share/classes/javax/security/auth/kerberos/DelegationPermission.java 
2013-11-14 07:44:04.718682612 +0000
@@ -48,14 +48,14 @@
   * <p>
   * For example, to specify the "host" service use of a forwardable TGT the
   * target permission is specified as follows:
- * <p>
+ * <br/>
   * <pre>
   *  DelegationPermission("\"host/foo.example.com at EXAMPLE.COM\" 
\"krbtgt/EXAMPLE.COM at EXAMPLE.COM\"");
   * </pre>
   * <p>
   * To give the "backup" service a proxiable nfs service ticket the 
target permission
   * might be specified:
- * <p>
+ * <br/>
   * <pre>
   *  DelegationPermission("\"backup/bar.example.com at EXAMPLE.COM\" 
\"nfs/home.EXAMPLE.COM at EXAMPLE.COM\"");
   * </pre>

Otherwise, the patch looks fine.

-Joe

On 11/14/2013 07:01 AM, Sean Mullan wrote:
> Just one comment. I would prefer if you changed the following pattern:
>
> *
> * <p>
> *
>
> to:
>
> *
>
> instead of:
>
> *
> *
>
> There is no need for the extra line.
>
> Thanks,
> Sean
>
> On 11/14/2013 03:44 AM, Sergey Lugovoy wrote:
>> Hi all,
>>
>> please review the fix
>>
>> http://cr.openjdk.java.net/~yan/8028266/webrev.00/
>>
>> for
>>
>> https://bugs.openjdk.java.net/browse/JDK-8028266
>>
>> This patch cleanup tidy warnings for generated html documentation, and
>> do not
>>
>> affect the appearance of the documentation.
>>
>> Best regards,
>>
>> Serge V. Lugovoy
>>
>