[security dev] [8] Review request for JDK-8028266 : Tidy warnings cleanup for packages java.security/javax.security

[Yuri Nesterenko]

Let's not create a backlog of stale documentation changes!
If I may, I do approve this fix.

Thanks,
-yan

On 11/15/2013 11:40 AM, Sergey Lugovoy wrote:
> Hi all,
> Please, see to second patch
> http://cr.openjdk.java.net/~yan/8028266/webrev.01/
> for
> https://bugs.openjdk.java.net/browse/JDK-8028266
>
> I removed some extra lines left after <p> removal, as Sean suggested.
> As to the fact why I replaced "<p><pre>" by "<br/><pre>" - that's because "p"
> element represents a paragraph and cannot contain another block elements
> ("<pre>" or "<div>")
> ( see more http://www.w3.org/TR/html401/struct/text.html#h-9.3.1)
>
> On Thursday, November 14, 2013 11:12:29 AM Joe Darcy wrote:
>> Might just be my limited knowledge of HTML, but I don't understand the
>> replacement of <p> with <br/> in several places like:
>>
>> ---
>> old/src/share/classes/javax/security/auth/kerberos/DelegationPermission.java
>> 2013-11-14 07:44:04.878682607 +0000
>> +++
>> new/src/share/classes/javax/security/auth/kerberos/DelegationPermission.java
>> 2013-11-14 07:44:04.718682612 +0000
>> @@ -48,14 +48,14 @@
>>     * <p>
>>     * For example, to specify the "host" service use of a forwardable TGT the
>> * target permission is specified as follows:
>> - * <p>
>> + * <br/>
>>     * <pre>
>>     *  DelegationPermission("\"host/foo.example.com at EXAMPLE.COM\"
>> \"krbtgt/EXAMPLE.COM at EXAMPLE.COM\"");
>>     * </pre>
>>     * <p>
>>     * To give the "backup" service a proxiable nfs service ticket the
>> target permission
>>     * might be specified:
>> - * <p>
>> + * <br/>
>>     * <pre>
>>     *  DelegationPermission("\"backup/bar.example.com at EXAMPLE.COM\"
>> \"nfs/home.EXAMPLE.COM at EXAMPLE.COM\"");
>>     * </pre>
>>
>> Otherwise, the patch looks fine.
>>
>> -Joe
>>
>> On 11/14/2013 07:01 AM, Sean Mullan wrote:
>>> Just one comment. I would prefer if you changed the following pattern:
>>>
>>> *
>>> * <p>
>>> *
>>>
>>> to:
>>>
>>> *
>>>
>>> instead of:
>>>
>>> *
>>> *
>>>
>>> There is no need for the extra line.
>>>
>>> Thanks,
>>> Sean
>>>
>>> On 11/14/2013 03:44 AM, Sergey Lugovoy wrote:
>>>> Hi all,
>>>>
>>>> please review the fix
>>>>
>>>> http://cr.openjdk.java.net/~yan/8028266/webrev.00/
>>>>
>>>> for
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8028266
>>>>
>>>> This patch cleanup tidy warnings for generated html documentation, and
>>>> do not
>>>>
>>>> affect the appearance of the documentation.
>>>>
>>>> Best regards,
>>>>
>>>> Serge V. Lugovoy