[8] RFR 8028377: test/sun/security/provider/KeyStore/DKSTest.sh attempts to write to ${test.src}

Weijun Wang weijun.wang at oracle.com
Tue Nov 19 06:30:49 PST 2013


Why not just put the file in the current directory? That's the real 
scratch dir. Or the cfg file needs an absolute path?

Also, is it necessary to remove the files in finally? If the test fails, 
the files will be retained by jtreg so we can look into the reason. Or, 
these lines are added to make sure the files are removable? But then I 
think File::delete will not fail if a file is not removable. 
Files::delete is better.

Thanks
Max


On 11/19/13, 22:16, Vincent Ryan wrote:
> Please review the following test fix:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8028377
> Webrev: http://cr.openjdk.java.net/~vinnie/8028377/webrev.00/
>
> It now writes temporary keystores in the test scratch area
> (not the test source area).
>
> Thanks.


More information about the security-dev mailing list