[8] Request for review: 8008296: keytool utility doesn't support '-importpassword' command

[Weijun Wang]

I don't have other issues. Have you updated the webrev? I see no change.

--Max

On 10/3/13 9:57 PM, Vincent Ryan wrote:
> Thanks for the comments - I'm just returning to this following JavaOne.
>
> I've updated the Help messages to add a separate section for '-importpass' and
> I've reverted the prompt to its previous value: 'Enter the password to be stored'.
>
> Let me know if there are any other issues. Otherwise I'd like to push this today.
>
>
> On 19 Sep 2013, at 00:51, Weijun Wang wrote:
>
>> Hi Vinnie
>>
>> Mostly good, but do you need to add a help line for it? You reuse the GENSECKEY command so "keytool -importpass -help" looks strange.
>>
>> Also, the command name is -importpassword but the prompt is "Enter the passphrase to be stored". Feel a little uncomfortable.
>>
>> Thanks
>> Max
>>
>>
>> On 9/14/13 2:25 AM, Vincent Ryan wrote:
>>>
>>> Please review the following fix that adds support to the keytool utility for storing arbitrary user passwords
>>> in a keystore. For keystores such as PKCS#12 that support a variety of key protection algorithms,
>>> the PBE algorithm may also be specified by overloading the existing -keyalg flag. For example,
>>>
>>>      % keytool -importpassword -storetype PKCS12 -keyalg PBEWithHmacSHA1AndAES_128 ...
>>>
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008296
>>> Webrev: http://cr.openjdk.java.net/~vinnie/8008296/webrev.00/
>>>
>>> Thanks.
>>>
>>>
>