Code Review Request for 8025967 "addition of -Werror broke the old build"

Vincent Ryan vincent.x.ryan at oracle.com
Sat Oct 5 16:28:45 UTC 2013


Your changes look fine.

On 04/10/2013 23:24, Valerie (Yu-Ching) Peng wrote:
>
> Well, can someone please review the following trivial fix today or early
> Monday?
> 8025967: addition of -Werror broke the old build
>
> JCE is still using the legacy build and as a result, I have to fix build
> warnings in other components in order for the whole build to succeed.
> The changes are all about addressing the javac raw type warnings.
> I want to keep changes to a minimum, thus I only changed the
> private/implementation related ones and used annotation to disable the
> warnings in all public APIs and some private ones where there are
> dependencies, e.g. JNI.
>
> Webrev can be found at:  http://cr.openjdk.java.net/~valeriep/8025967/
>
> Thanks!
> Valerie
>




More information about the security-dev mailing list