Code Review Request for 8025967 "addition of -Werror broke the old build"

Valerie (Yu-Ching) Peng valerie.peng at oracle.com
Mon Oct 7 18:14:00 UTC 2013


Thanks Vinnie for the review~
Forwarding this request to core-libs-dev per Sean's suggestion.
Changes are for getting rid of compiler warnings in order for JCE 
provider build (still using the old build process) to complete 
successfully - either add the annotation to suppress rawtype warnings or 
change local declarations from Class[] to Class<?>[].

If there are concerns, please let me know by EOB today as I have to get 
JCE changes integrated before leaving for vacation.
Thanks,
Valerie

On 10/07/13 08:41, Sean Mullan wrote:
> I would also send this to core-libs-dev for someone to look over the 
> non-security component changes.
>
> --Sean
>
> On 10/04/2013 06:24 PM, Valerie (Yu-Ching) Peng wrote:
>>
>> Well, can someone please review the following trivial fix today or early
>> Monday?
>> 8025967: addition of -Werror broke the old build
>>
>> JCE is still using the legacy build and as a result, I have to fix build
>> warnings in other components in order for the whole build to succeed.
>> The changes are all about addressing the javac raw type warnings.
>> I want to keep changes to a minimum, thus I only changed the
>> private/implementation related ones and used annotation to disable the
>> warnings in all public APIs and some private ones where there are
>> dependencies, e.g. JNI.
>>
>> Webrev can be found at:  http://cr.openjdk.java.net/~valeriep/8025967/
>>
>> Thanks!
>> Valerie
>>
>




More information about the security-dev mailing list