[8] Review Request for 8007292 : Add JavaFX internal packages to package.access

[David Holmes]

Hi Sean,

Not a full review.

On 9/10/2013 5:52 AM, Sean Mullan wrote:
> Please review the fix for the following bug:
>
>    https://bugs.openjdk.java.net/browse/JDK-8007292
>
> This bug requires build changes and a new build tool to add additional
> restricted packages to the java.security file which are not part of
> OpenJDK. These packages are only added when doing a build including the
> open and closed sources.
>
> The restricted packages and new test are in the closed sources and will
> be reviewed separately.
>
> webrev: http://cr.openjdk.java.net/~mullan/webrevs/8007292/webrev.00/

Based on your description and the ifndef OPENJDK it sounds to me that 
this doesn't belong in the OpenJDK makefiles.

That aside I would think the CP+RM could be changed to a MV.

In the tool this code doesn't show correct use of try-with-resources:

51         try (BufferedReader br = new BufferedReader(new 
FileReader(args[0]));
   52              BufferedWriter bw = new BufferedWriter(new 
FileWriter(args[1]))) {

The FileReader and FileWriter should also be covered by TWR:

   try (FileReader fr = new FileReader(args[0]);
        BufferedReader br = new BufferedReader(fr);
        FileWriter fw = new FileWriter(args[1]);
        BufferedWriter bw = new BufferedWriter(fw)) {


Finally do we still use make/tools/Makefile in the new build?

David
-----

> Thanks,
> Sean