<AWT Dev> Code review request: 7025699: Policy Tool is not accessible by keyboard

[Anthony Petrov]

Hi Max,

I don't have expertise in this code so I haven't reviewed the fix 
thoroughly. I'd like to point out one thing though: unlike AWT, Swing is 
a single-threaded GUI toolkit. While in AWT you can create 
components/windows and call APIs on any thread, in Swing everything 
GUI-related must be performed on the Event Dispatch Thread (EDT) only. 
Any long, non-GUI-related operations (like I/O, computations, etc.) 
should be dispatched on other threads (with a SwingWorker, for example).

I don't see a single SwingUtilities.invokeLater/invokeAndWait() call in 
PolicyTool.java, so I thought I'd ask whether you're aware of the 
threading limitations imposed by Swing and how those are going to be 
addressed?

--
best regards,
Anthony

On 10/12/2013 04:49 AM, Weijun Wang wrote:
> Hi All
>
> Please review the fix at
>
>     http://cr.openjdk.java.net/~weijun/7025699/webrev.00/
>
> The fix includes porting PolicyTool from AWT to Swing, defining
> mnemonics for menu items and buttons, and adding keyboard shortcuts for
> the File -> New/Open/Save items. Several tests are updated also.
>
> Thanks
> Max