[8] Request for Review: 8025287: NPE in api/java_security/cert/PKIXRevocationChecker/GeneralTests_GeneralTests

[Sean Mullan]

Hi Jason,

The fix looks good. Even though there is a TCK test for this, I think 
you should add a regression test, and it should be very easy to add. You 
can add it to 
jdk/test/java/security/cert/PKIXRevocationChecker/UnitTest.java, ex:

$ hg diff UnitTest.java
diff -r 54869853c06c 
test/java/security/cert/PKIXRevocationChecker/UnitTest.java
--- a/test/java/security/cert/PKIXRevocationChecker/UnitTest.java
+++ b/test/java/security/cert/PKIXRevocationChecker/UnitTest.java
@@ -44,6 +44,8 @@
          CertPathChecker cpc = cpv.getRevocationChecker();
          PKIXRevocationChecker prc = (PKIXRevocationChecker)cpc;

+        prc.init(false);
+
          System.out.println("Testing that get methods return null or " +
                             "empty lists/sets/maps");
          requireNull(prc.getOcspResponder(), "getOcspResponder()");


--Sean

On 10/21/2013 08:12 PM, Jason Uh wrote:
> Hi Sean,
>
> Could I please get a review of this changeset?
>
> The change checks for null params when RevocationChecker.init is called.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8025287
> Webrev: http://cr.openjdk.java.net/~juh/8025287/webrev.00/
>
> Thanks,
> Jason