RFR: JDK-8027624 - com/sun/crypto/provider/KeyFactory/TestProviderLeak.java unstable again

Bradford Wetmore bradford.wetmore at oracle.com
Thu Oct 31 15:24:07 PDT 2013


Looks good, thanks for looking at this, Dan!

Brad


On 10/31/2013 3:05 PM, Dan Xu wrote:
> Hi All,
>
> Please help review a simple change towards the testcase,
> TestProviderLeak.java.
>
> In the call of SecretKeyFactory.getInstance(), it will try to access
> files under temporary directory by calling File.list() method. And this
> list() method may consume a lot of memory if there are large amount of
> files inside. In such case, it will cause OutOfMemory error and fail the
> test. As the contents in the tmp directory vary at different time and on
> different machines, it leads to the fragility of this test. In the
> change, it moves eatupMemory() method close to the testing iteration to
> avoid the memory consumption in non-testing codes.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8027624
> Webrev: http://cr.openjdk.java.net/~dxu/8027624/webrev/
> <http://cr.openjdk.java.net/%7Edxu/8027624/webrev/>
>
> Thanks,
>
> -Dan


More information about the security-dev mailing list