Code review request, JKD-8024068 sun/security/ssl/javax/net/ssl/ServerName/IllegalSNIName.java fails

Weijun Wang weijun.wang at oracle.com
Mon Sep 2 02:45:44 UTC 2013


Code change looks fine.

--Max

On 9/2/13 10:41 AM, Xuelei Fan wrote:
> On 9/2/2013 10:38 AM, Xuelei Fan wrote:
>> Hi Weijun,
>>
>> Please review this simple test fix.  There is a typo in the test. The
>> issue is exposed after the fix of JDK-8023881.
>>
>> webrev: http://cr.openjdk.java.net/~xuelei/8024068/webrev.00/
>>
>> This bug may not have been published to bugs.sun.com.  The typo and the
>> patch look like:
>>
>>           String[] illegalNames = {
>> -                "example\u3003\u3002com",
>> +                "example\u3002\u3002com",
>>                   "example..com",
>>                   "com\u3002",
>>                   "com.",
>>                   "."
>>               };
>>
> Note that "\u3002" is a kind of dot code point (ideographic full stop)
> per RFC 3490.
>
> Xuelei
>
>> "\u3003" now is acceptable as a Unicode code point, and then result in
>> test failure.
>>
>> Thanks,
>> Xuelei
>>
>



More information about the security-dev mailing list