Code Review Request: 7122707 update Security Providers to JDK8

[Xuelei Fan]

On 9/17/2013 9:44 AM, Anthony Scarpino wrote:
> On 09/16/2013 06:27 PM, Xuelei Fan wrote:
>> src/macosx/classes/apple/security/AppleProvider.java
>> ====================================================
>> I'm not sure apple provider is using the JDK version as the provider
>> version.
>> -        super("Apple", 1.1, info);
>> +        super("Apple", 1.8d, info);
>>
>> src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java
>> ==================================================================
>> As above, I'm not sure native JGSS provider is using JDK version as the
>> provider version.
>> -        super(NAME, 1.0, INFO);
>> +        super(NAME, 1.8d, INFO);
>>
>> Should not a problem, but nice to get confirm from Max, and the
>> component owner of apple provider.
> 
> Some of us were talking locally about updating providers to the current
> JDK version even if they hadn't been modified.  So if there is a certain
> set that shouldn't be changed, then we should specify a criteria..
> 
I was just wondering why the version number start with 1.1 or 1.0. They
are not old providers for JDK 1.0 or 1.1.  I think above two providers
are introduced recently. Not sure about the history.  I prefer to be
consistent with JDK releases. But better to check with the owner.

Xuelei

> 
>>
>> src/share/classes/sun/security/pkcs11/SunPKCS11.java
>> ====================================================
>> -        super("SunPKCS11-Dummy", 1.7d, "SunPKCS11-Dummy");
>> +        super("SunPKCS11", 1.8d, "SunPKCS11");
>>
>> I think the real provider name should be "SunPKCS11-ConfigName".  I'm
>> not sure about this fix.  Vinnie may have comments here.
> 
> I forgot to put back the "Dummy" after I realized what it meant.  I'll
> update that.  thanks
> 
> Tony
> 
>>
>> Otherwise, looks fine to me.
>>
>> Xuelei
>>
>> On 9/17/2013 7:21 AM, Anthony Scarpino wrote:
>>> Hi,
>>>
>>> I'd like a review of these quick changes to the security providers.
>>> 7122707 Security Providers need to have their version numbers updated
>>> for JDK8
>>>
>>> http://cr.openjdk.java.net/~ascarpino/7122707/webrev.00/
>>>
>>> thanks
>>>
>>> Tony
>>
>