[8] Request for review: 8008296: keytool utility doesn't support '-importpassword' command

[Weijun Wang]

Hi Vinnie

Mostly good, but do you need to add a help line for it? You reuse the 
GENSECKEY command so "keytool -importpass -help" looks strange.

Also, the command name is -importpassword but the prompt is "Enter the 
passphrase to be stored". Feel a little uncomfortable.

Thanks
Max


On 9/14/13 2:25 AM, Vincent Ryan wrote:
>
> Please review the following fix that adds support to the keytool utility for storing arbitrary user passwords
> in a keystore. For keystores such as PKCS#12 that support a variety of key protection algorithms,
> the PBE algorithm may also be specified by overloading the existing -keyalg flag. For example,
>
>      % keytool -importpassword -storetype PKCS12 -keyalg PBEWithHmacSHA1AndAES_128 ...
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008296
> Webrev: http://cr.openjdk.java.net/~vinnie/8008296/webrev.00/
>
> Thanks.
>
>