RFR 8035986: KerberosKey algorithm names are not specified

Weijun Wang weijun.wang at oracle.com
Wed Apr 9 00:53:12 UTC 2014


There is already getKeyType() and toString(). Also I don't think 
"kid-2014" is useful. If people really want to inspect the result, I 
expect they would fall into the "default" or "else" block anyway.

--Max

On 4/9/2014 7:57, Xuelei Fan wrote:
> Looks fine to me.
>
> I was wondering, whether it is a little bit more instinctive to return a
> string with the type number for "unknown" and "private" algorithm in
> KerberosKey.getAlgorithm().  For example:
>
>      "unknown" -> "kid-2014"
>      "private" -> "kid-(2014)"
>
> Thanks,
> Xuelei
>
> On 4/8/2014 10:37 AM, Weijun Wang wrote:
>> Hi All
>>
>> Please review the code changes at
>>
>>     http://cr.openjdk.java.net/~weijun/8035986/webrev.00/
>>
>> It's about using IANA names in KerberosKey instead of old non-standard
>> names.
>>
>> Thanks
>> Max
>


More information about the security-dev mailing list