Code review request, 8037557 test timeout

Weijun Wang at
Fri Apr 11 01:36:08 UTC 2014

On 4/11/2014 7:10, Xuelei Fan wrote:
>> What does that thread.join(120000) do? Is it possible that after it
>> finishes no exception was thrown yet and your test shown as succeeded?
> IO exception should be thrown when the client cannot read and write.

This is what I am worried about:

Suppose serverThread.join(120000) timeouts. At this time, somewhere 
inside server thread is waiting. Now the main thread starts executing 
lines 374- and since no exception has been thrown it will execute to 
line 416 and the main thread exits without a problem. After a while, the 
server thread fails but since its exception is stored in a variable 
(serverException) and not thrown out, the test seems to pass.

Why are thread.join() necessary? Except for socket timeout, are you 
expecting other calls spending too much time?


> Thanks,
> Xuelei

> >>>>>

More information about the security-dev mailing list