Code review request, 8037557 test timeout

Xuelei Fan at
Fri Apr 11 02:58:36 UTC 2014


On 4/11/2014 10:36 AM, Weijun Wang wrote:
> On 4/11/2014 10:15, Xuelei Fan wrote:
>> When line 374 get called, the test is nearly done (client complete its
>> jobs, and server accepted all connections).
> If it's nearly done and no bad thing will happen, then you don't need to
> call serverThread.join(120000). Otherwise, you risk a false success.
It's nearly done, and bad thing may still happen (Threads may have not
scheduled to completed, and join may be still cannot return within the
overall testing timeout).

OK. From the debug log, this should not be the cause of the timeout.
Removed this update.


> Is there a way to find out if the exit of thread.join(time) is due to
> thread exit or timeout? If so, you can throw an exception if it's a
> timeout.
> --Max

More information about the security-dev mailing list