Code review request, a simple fix to remove the incorrect comment in RSAClientKeyExchange.java

Xuelei Fan xuelei.fan at oracle.com
Tue Apr 29 14:05:19 UTC 2014


Hi,

As this is a simple comment fix, I will not generate a webrev as general.

In sun/security/ssl/RSAClientKeyExchange.java:

116   // Cannot generate key here, please don't use Cipher.UNWRAP_MODE!
117   cipher.init(Cipher.UNWRAP_MODE, privateKey,
118           new TlsRsaPremasterSecretParameterSpec(
119                   maxVersion.v, currentVersion.v),
120           generator);

We've a comment indicating not to use UNWRAP_MODE. However, in line 117,
the UNWRAP_MODE is used instead in a recent fix.  The comment need to
go.  I will remove line 116 in this fix.

-   // Cannot generate key here, please don't use Cipher.UNWRAP_MODE!

Thanks,
Xuelei



More information about the security-dev mailing list