RFR 6562449: LoginContext does not all allow overloading of login method in LoginModule

Wang Weijun weijun.wang at oracle.com
Tue Aug 19 00:26:48 UTC 2014


 912             return modClass.getMethod(methodName, parameters);

It would be better to call LoginModule.class.getMethod().

Also, do you want to add a test case that includes a good login() method but the class not extending LoginModule? This would show our fallback still works.

Thanks
Max

On Aug 19, 2014, at 6:33, Jamil Nimeh <jamil.j.nimeh at oracle.com> wrote:

> Ping!  Any takers out there?
> 
> Many thanks,
> --Jamil
> 
> On 08/11/2014 02:56 PM, Jamil Nimeh wrote:
>> Hello all,
>> 
>> This webrev covers a fix to LoginContext so it no longer selects the wrong method when a LoginModule method (login, logout, commit, etc.) has been overloaded.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-6562449
>> Webrev: http://cr.openjdk.java.net/~ascarpino/6562449/webrev.01
>> 
>> Thank you,
>> --Jamil
> 



More information about the security-dev mailing list