Replace concat String to append in StringBuilder parameters

Wang Weijun weijun.wang at oracle.com
Thu Aug 21 15:04:28 UTC 2014


I also see a lot of .toString() and String.valueOf() calls.

$ cat string_concat_updated.patch | perl -ne 'print if /^\+ .*append.*(String\.valueOf|\.toString\(\))/' | wc
      62     210    4626

Wrapped lines not indented correctly in

src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/AbstractSerializer.java
src/java.base/share/classes/com/sun/crypto/provider/DHParameters.java
src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java
src/java.base/share/classes/com/sun/crypto/provider/GCMParameters.java

--Max


More information about the security-dev mailing list