[Update] Re: RFR 6562449: LoginContext does not all allow overloading of login method in LoginModule
Wang Weijun
weijun.wang at oracle.com
Fri Aug 22 01:29:33 UTC 2014
Code change looks fine, but you will need to translate the file path to new module style.
There are also 2 useless imports:
import java.util.LinkedList;
import java.security.AccessController;
--Max
On Aug 22, 2014, at 9:12, Jamil Nimeh <jamil.j.nimeh at oracle.com> wrote:
> One more update, with Max's nits addressed:
>
> http://cr.openjdk.java.net/~weijun/6562449/webrev.03
>
> --Jamil
>
> On 08/20/2014 02:38 PM, Jamil Nimeh wrote:
>> Hello everyone,
>>
>> This is an updated review that addresses comments from the original webrev.
>>
>> http://cr.openjdk.java.net/~ascarpino/6562449/webrev.02
>>
>> Thank you,
>> --Jamil
>>
>> On 08/11/2014 02:56 PM, Jamil Nimeh wrote:
>>> Hello all,
>>>
>>> This webrev covers a fix to LoginContext so it no longer selects the wrong method when a LoginModule method (login, logout, commit, etc.) has been overloaded.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-6562449
>>> Webrev: http://cr.openjdk.java.net/~ascarpino/6562449/webrev.01
>>>
>>> Thank you,
>>> --Jamil
>>
>
More information about the security-dev
mailing list